Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probably more efficient to have TreeNode's location field be a Path rather than a PathBuf #5

Closed
solidiquis opened this issue May 8, 2022 · 0 comments
Closed

Probably more efficient to have TreeNode's location field be a Path rather than a PathBuf #5

solidiquis opened this issue May 8, 2022 · 0 comments

Comments

@solidiquis
Copy link
Owner

erdtree/src/file_tree/tree_node.rs

Line 40 in 09ff686

location: location.as_ref().to_path_buf(),

TreeNode is creating a new PathBuf when it could probably just be a Path which is an unsized type and therefore must always be borrowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solidiquis