Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for generating shell completions #79

Closed
Brezak opened this issue Mar 16, 2023 · 3 comments · Fixed by #82
Closed

[feature] Add support for generating shell completions #79

Brezak opened this issue Mar 16, 2023 · 3 comments · Fixed by #82

Comments

@Brezak
Copy link
Contributor

Brezak commented Mar 16, 2023

There are 2 ways this could be done:

  • A build script like dust does it
  • A flag similar to how mdBook does it

I've tried to implement both solutions and the build script solution would require changing how imports are done since just including the context module essentially means having to include almost the entire project module hierarchy.

@solidiquis
Copy link
Owner

Thanks @Brezak for tackling this! I'll do my best to take a look at this and give you my thoughts sometime tonight or tomorrow :]

@Brezak
Copy link
Contributor Author

Brezak commented Mar 16, 2023

@solidiquis should have mentioned this but I've also made an attempt at implementing the flag approach if you wanna take a look at how it could work.

@solidiquis
Copy link
Owner

@Brezak I do like the flag approach as it feels far less awkward in my opinion. Not a huge fan of the duplicate code in the build.rs as it can be painful for people knowing that they need to sync up changes between that and main.rs, utils.rs etc.. Let me know your thoughts. Feel free to whip up a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants