Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import { signOut } from "@solid-mediakit/auth"; gives error. #60

Closed
birkskyum opened this issue Apr 26, 2024 · 2 comments
Closed

import { signOut } from "@solid-mediakit/auth"; gives error. #60

birkskyum opened this issue Apr 26, 2024 · 2 comments

Comments

@birkskyum
Copy link

It's a bit troublesome that signOut can be imported from both

import { signOut } from "@solid-mediakit/auth";

and

import { signOut } from "@solid-mediakit/auth/client";

but that only the latter won't break ones code.

@OrJDev
Copy link
Collaborator

OrJDev commented Apr 27, 2024

It's a bit troublesome that signOut can be imported from both

import { signOut } from "@solid-mediakit/auth";

and

import { signOut } from "@solid-mediakit/auth/client";

but that only the latter won't break ones code.

The first signOut is for the server, i don't think its necessary to even export that as it has no use currently, but yes it just a utility for the server. I should probably make a pr when im able to and un-export that.

@OrJDev
Copy link
Collaborator

OrJDev commented Jul 24, 2024

this was fixed in latest version, renamed the server sign in / out.

@OrJDev OrJDev closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants