Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change deps versions from "workplace" to "^0.1.0" #30

Merged
merged 1 commit into from Jun 16, 2022

Conversation

thetarnav
Copy link
Member

  • Change dependency versions of packages from "workspace^" to "^0.1.0" (current version) — Fixes  No matching version found for @solid-aria/types@* inside the workspace #29
    0.1.0 instead of 0.1.1 because changesets should update those

  • Move solid-primitives packages from peerDependencies to dependencies.
    Those are normal dependencies. This may cause missing peerdependency warnings during installs (in this repo), to do that we'd have to add "solid-js" as dev dependency everywhere, but I just didn't have the strength to do it. The warnings are harmless anyway...

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2022

🦋 Changeset detected

Latest commit: 2ca4cfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@solid-aria/breadcrumbs Patch
@solid-aria/button Patch
@solid-aria/checkbox Patch
@solid-aria/collection Patch
@solid-aria/dialog Patch
@solid-aria/focus Patch
@solid-aria/i18n Patch
@solid-aria/interactions Patch
@solid-aria/label Patch
@solid-aria/link Patch
@solid-aria/list Patch
@solid-aria/listbox Patch
@solid-aria/menu Patch
@solid-aria/overlays Patch
@solid-aria/primitives Patch
@solid-aria/radio Patch
@solid-aria/selection Patch
@solid-aria/switch Patch
@solid-aria/toggle Patch
@solid-aria/tree Patch
@solid-aria/types Patch
@solid-aria/utils Patch
@solid-aria/visually-hidden Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thetarnav thetarnav requested a review from fabien-ml June 16, 2022 19:47
@fabien-ml
Copy link
Member

If we put solid-primitives as deps instead of peer deps, user may have version conflict when trying to install them.

@thetarnav
Copy link
Member Author

thetarnav commented Jun 16, 2022

And having them as peer solves that? Don't package managers take care of that already?
If we don't update deps there will be issues with incompatible versions anyway.
solid-primitives are just normal dependencies that are necessary, the user shouldn't have to worry about installing/managing them
If you were using clsx, would you put it as a peer dependency? That doesn't make sense...

@fabien-ml fabien-ml merged commit b21b76d into main Jun 16, 2022
@fabien-ml fabien-ml deleted the fix-deps-versions branch June 17, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

 No matching version found for @solid-aria/types@* inside the workspace
2 participants