Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup SSR testing #43

Merged
merged 8 commits into from Jun 18, 2022
Merged

Setup SSR testing #43

merged 8 commits into from Jun 18, 2022

Conversation

thetarnav
Copy link
Member

@thetarnav thetarnav commented Jun 18, 2022

Having automatic tests specifically for SSR should help ensure that solid-aria can be used with solid-start without trouble.
Not that it's certain that it'll run, we've seen that there are a lot of random things, especially with jsx transform that could go wrong. But the API itself should benefit from this.

  • moved some of the configs to new /configs dir — frees some space in the root
  • Added jest config & setup files specifically for ssr
  • Added ssr tests to label package (It's a only a start😄)
  • Fixed createSlotId to prevent it from accessing DOM APIs on the server.

Should I add a changeset for all packages, or only the updated utils?

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2022

⚠️ No Changeset found

Latest commit: 489f9f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fabien-ml
Copy link
Member

fabien-ml commented Jun 18, 2022

I don't think there is a need to release for now, maybe when we have more component related primitives done. I've set the release action manual btw.

@fabien-ml fabien-ml merged commit 0b30b58 into main Jun 18, 2022
@thetarnav thetarnav deleted the ssr-test branch June 21, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants