Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data reconcilation for cached functions works incorrectly under some conditions #343

Closed
elite174 opened this issue Dec 29, 2023 · 1 comment

Comments

@elite174
Copy link

Describe the bug

On the first cache revalidation, data is reconciled incorrectly, which causes rerenders.

Example:
https://playground.solidjs.com/anonymous/b6b25440-9d66-467e-94ee-5148484a5bc2

You'll see in the console that items are rerendered on the first revalidation, however it doesn't happen when you continue revalidate the data.

Your Example Website or App

https://playground.solidjs.com/anonymous/b6b25440-9d66-467e-94ee-5148484a5bc2

Steps to Reproduce the Bug or Issue

Check out the example

Expected behavior

Items should be reconciled correctly without rerenders

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

No response

@ryansolid
Copy link
Member

ryansolid commented Jan 4, 2024

Thanks.. I missed this. I'm trying to track this one down but its odd.. Somehow on first load we aren't getting the wrapped value. I see it.. empty intent on initial load. Ok I will get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants