Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handleAnchor and blob links #382

Open
titoBouzout opened this issue Feb 20, 2024 · 2 comments
Open

handleAnchor and blob links #382

titoBouzout opened this issue Feb 20, 2024 · 2 comments

Comments

@titoBouzout
Copy link

titoBouzout commented Feb 20, 2024

Seems like handleAnchor errors when the link is a blob, like in the solid playground https://playground.solidjs.com/anonymous/778914e0-e4ea-4292-90e4-236336d33e61

@titoBouzout
Copy link
Author

It seems like a.href doesn't have a complete URI when a link is in a blob. Maybe you can check if a.hostname is empty and somehow construct the full URI.

const href = svg ? a.href.baseVal : a.href;

I wanted to send a pull request, but all the basePath stuff is mysterious enough. It costs nothing to add 1 line comment on a logic condition on the lines of "this check for X because Y and Z happens"

@ryansolid
Copy link
Member

Honestly I don't know. Which is sort of the challenge with the router. Most the core logic was authored by the previous maintainer, and then was augmented by the community. I've been looking for people interested in helping maintaining the router because I haven't had the chance to look that deeply in how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants