Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial lesson selector does not close after selection #158

Closed
fictitious opened this issue Sep 22, 2021 · 4 comments
Closed

Tutorial lesson selector does not close after selection #158

fictitious opened this issue Sep 22, 2021 · 4 comments

Comments

@fictitious
Copy link
Contributor

Started happening after the Sep 21 update from the dev branch with router updated to 0.1.5, i18n updates etc.

I tried to debug - clicking on NavLink list item changes the route, DirectoryMenu receives the new current item in props, firing the effect that calls setShowDirectory(false), but it looks like the listContainer that should receive hidden class is not re-rendered.

Clicking on the <button> with chevron that shows/hides DirectoryMenu directly without involving route change works.

@davedbase
Copy link
Member

davedbase commented Sep 22, 2021

Thanks for letting us know. Actually looks like the "Solve" button was regressed as well but I've at least managed to patch that. Haven't had a chance to dig into the dropdown yet.

@fictitious
Copy link
Contributor Author

The dropdown starts working again if I downgrade solid-js version to 1.1.0. Which makes me think that it's related to this change.

@ryansolid
Copy link
Member

There were some bugs there but hopefully they are all fixed by 1.1.5.

@davedbase
Copy link
Member

The production site was deployed last night on 1.1.5 so the issue with the dropdown seems to be unresolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants