Update merge-anything to 5.0.0 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s handled by dom expressions
remove redundant textContent = '' for HMR since as of solid 0.21.0 it's handled by dom expressions
Extensions option added
We don't need the solid-refresh transform during SSR and it could cause issues. Better to disable it. During SSR, the HMR is handled at the module level by Vite itself
Disable solid-refresh transform during SSR
This reverts commit 166554e.
|
Thank you! |
amoutonbrady
added a commit
that referenced
this pull request
Jan 26, 2022
Update merge-anything to 5.0.0
|
@amoutonbrady glad I could help :) |
|
Oh that was release last night actually! Available in 2.2.5 :) |
|
Oh I see! I was checking https://github.com/solidjs/vite-plugin-solid/releases 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28 by updating to merge-anything@5.0.0. Since you declare that
I think this is not a breaking change