Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is Spree::Address.build_default not used? #3441

Closed
delphaber opened this issue Nov 28, 2019 · 2 comments · Fixed by #3548
Closed

Why is Spree::Address.build_default not used? #3441

delphaber opened this issue Nov 28, 2019 · 2 comments · Fixed by #3548
Labels
type:enhancement Proposed or newly added feature

Comments

@delphaber
Copy link
Contributor

Hey! This is not a feature request actually. But it's not a bug either ;)

I've noticed that here in the checkout controller Solidus is building a new address with a default attribute (country_id).

I'm wondering why can't we use Spree::Address.build_default in the controller? 🤔

Is there a reason? If not, would you consider a PR for this? :)

@kennyadsl
Copy link
Member

I think you are right @delphaber, I couldn't find a good reason browsing the git history either. So I think it would be a good PR.

Thanks for spotting it!

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Nov 28, 2019
@softr8
Copy link
Contributor

softr8 commented Dec 3, 2019

I think it has to be with the state select box, it needs to be initialized with the current country, will try to confirm it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Proposed or newly added feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants