Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate to add Webpacker support #107

Open
blocknotes opened this issue Oct 2, 2020 · 4 comments
Open

Evaluate to add Webpacker support #107

blocknotes opened this issue Oct 2, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@blocknotes
Copy link
Contributor

We could add an option to the installer to copy the assets using the webpacker structure.

@blocknotes blocknotes added the enhancement New feature or request label Oct 2, 2020
@blocknotes blocknotes changed the title Evaluate Webpacker support Evaluate to add Webpacker support Oct 2, 2020
@blocknotes
Copy link
Contributor Author

This could be painful 😑 because we depend on external gems (Spree JS object) and we also have a .erb.js file (utils.js.erb).

@blocknotes
Copy link
Contributor Author

@ChristianRimondi / @kennyadsl: what do you think about this one?
If we go on considering the installation procedure that copy the files on the target project as the primary way we could just close this one (and optionally evaluate it if it becomes a real issue/request).

@kennyadsl
Copy link
Member

I'd keep it open and try to make an attempt to remove that js.erb file doing something that is also compatible with Webpacker, but after we have a clean installation process first.

@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 11, 2022
@gsmendoza gsmendoza removed the stale label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants