react hot loader 4.6 broken

[pungggi]

Hello first of all, great project!
I am not sure where to start explaining my issue maybe its here may be its react hot loader..
maybe its linaria.

I am using gatsby with react easy state.
gatsby 2.0.69 introduced a new version of react-hot -loader 4.6

Then I use a css in js solution called linaria.

As of this version Props passed to a styled` component are not hot updated if they are wrapped with view from react easy state..

For example:

Box.js

import { styled } from "linaria/react"

const Box = styled.div`
  color: ${(props) => (props.color ? props.color : "red")};

export default Box

then i consume

index.js

import { view } from 'react-easy-state'

export default view(() => {
  const classColor = css`
    color: green;
  `
  return (
     <Box padding={[30, 2, 10, 20]}>
       <div className={classColor}>
         <h1>About</h1>
       </div>
     </Box>
  )
})

If I change the classColor it updates.
But changing the value of the padding prop does not trigger a reload. This was working with gatsby 2.0.68 that uses react hot loader 4.5.

[solkimicreb]

Which version of react-easy-state are you using? v6.1.x migrated to React hooks when possible under the hood. Maybe the issue has to do something with that.

[pungggi]

I does not matter if 6.1.1 or 6.0.6 both behave the same in this case

[pungggi]

I setup a repo for reproduction

https://github.com/pungggi/rhl

see Branch hotload4_6 this uses the latest packages with react hot loader ^4.6.0

[solkimicreb]

Thanks! I will look into this.

…

On Sun, Feb 24, 2019, 22:26 pungggi ***@***.***> wrote: I setup a repo for reproduction https://github.com/pungggi/rhl see Branch hotload4_6 this uses the latest packages with react hot loader ^4.6.0 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGoj7n-X5dYTNUVtZxexBvThFZOxjIxyks5vQwOhgaJpZM4bOkYR> .

[pungggi]

opened an issue in react hot loader too.

[solkimicreb]

@pungggi Did you manage to solve this?

[buzinas]

@pungggi why was this issue closed? How can I make react-hot-loader work with react-easy-state?

[n3v3rd1e]

Hello, did anyone managed to solve this, or is it still not working?

[n3v3rd1e]

I do not mean to spam, but I feel like this is a really important issue and should not be ignored as it makes easy-state kinda not usable right now. Some statement about this would be highly appreciated, thank you.

[solkimicreb]

Looking into this. It seems to be an issue with functional components only. Did anyone have issues with class components and HMR?

[solkimicreb]

I just released v6.1.3 which hopefully fixes this issue 🎉 Please reopen it if the issue stays for any of you. Sorry for the long wait!

[n3v3rd1e]

Nice work perfectly, thanks 👍