batchedCallbacks memory leak in Chrome

[AMStrix]

First, thanks for an excellent library!

Second, there appears to be a memory leak for batched functions in Chrome.

• os: macOS 10.14.4
• browser: Chrome 74.0.3729.157
• react-easy-state@6.1.1
• react@16.8.6

I noticed the heap growing linearly in my app as it polls for data from a rest api. I narrowed it down to the batched callbacks mechanism in scheduler.js using the chrome devtools/Memory profiler.

The memory gets released when the globalObj batched method assignments are removed from scheduler.js.

devtools/Memory/Allocation instrumentation timeline

This behavior is also observable on the beer finder demo. With the Memory profiler - Allocation instrumentation on timeline running just repeatedly enter queries into the search.

beer finder

[solkimicreb]

Thanks for all the details! It feels good to see issues like this 🙂 I will look into this in a few hours.

[solkimicreb]

This should definitely be a WeakMap: https://github.com/solkimicreb/react-easy-state/blob/master/src/scheduler.js#L18. I will check if I made some other obvious mistakes with the batching. 🤦‍♂

[solkimicreb]

I just release a new patch (v6.1.2) which should fix this. Please reopen it if the issue is not fixed. Thanks for the nice detailed issue again 🙂

[AMStrix]

Upgraded, works great! Thanks for the quick turnaround on this.

Much appreciated and happy coding to you!