Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use consistent casing on helm install values (Namespaced -> namespaced) #1569

Closed
mitchdraft opened this issue Nov 1, 2019 · 0 comments
Closed

Comments

@mitchdraft
Copy link
Contributor

Is your feature request related to a problem? Please describe.
helm template values should be easy to write, consistent casing helps make it easier to write correct specs

Describe the solution you'd like
Change Namespaced to namespaced in the json spec https://github.com/solo-io/gloo/blob/master/install/helm/gloo/generate/values.go#L38
becoming:

Namespaced bool `json:"namespaced" desc:"use Roles instead of ClusterRoles"`

Additional context

This is a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants