Helm chart doesn't allow users to provide own ratelimit/extauth server in 1.x

[kdorosh]

No description provided.

[kdorosh]

We never supported helm value overrides (despite what the ratelimit docs may have hinted).

Still would be a nice feature to have, but not pressing.

Users can still configure settings appropriately using kubectl edit

[kdorosh]

We should also address this for extauth

[rickducott]

Not a clear need here, going to close.

[mveitas]

Is there a technical reason why this could not be added into the helm chart to avoid having to take the extra steps to perform some post processing via kubectl edit or post rendering with helm?

[eshepelyuk]

@kdorosh @rickducott can you reopen it ?

https://solo-io.slack.com/archives/C9L6VPAUW/p1606323414426800

[kdorosh]

Will reopen and mark as help wanted

[eshepelyuk]

Thnx @kdorosh going to provide a PR for extauth support.
Do you have tests some tests for chart rendering ?

[kdorosh]

Yes @eshepelyuk , they live at https://github.com/solo-io/gloo/tree/master/install/test

[eshepelyuk]

@kdorosh thanks, could you please provide a brief instruction how could I run only those tests, related to helm rendering ?
I have absolutely experience with golang and to figure out it myself it could take days, while the fix itsself is really simple.

[kdorosh]

@eshepelyuk you should be able to run the tests using ginkgo -r -failFast -trace -compilers=2 install/test.

Tests can go in install/test/helm_test.go . These tests import the helm2 and helm3 libraries, and ensure the tests pass with both versions of helm.