Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports header manipulation on direct responses #1912

Closed
marcogschmidt opened this issue Dec 12, 2019 · 2 comments
Closed

Supports header manipulation on direct responses #1912

marcogschmidt opened this issue Dec 12, 2019 · 2 comments
Assignees
@marcogschmidt
Labels
Area: Envoy activities related to envoy proxy Type: Enhancement New feature or request

Comments

@marcogschmidt
Copy link
Contributor

Currently Gloo skips the processing of route plugins on DirectResponseAction route actions. Since Envoy supports header manipulation on direct responses (see note here), we should process at least the header manipulation plugin on redirect actions.
@marcogschmidt marcogschmidt added Type: Enhancement New feature or request Area: Envoy activities related to envoy proxy labels Dec 12, 2019
@marcogschmidt marcogschmidt self-assigned this Dec 12, 2019
@EItanya
Copy link
Member

EItanya commented Dec 12, 2019

When you say header manipulation, do you mean via the transformation plugin? I am not sure that DirectResponseActions go through the filter chain. Will have to check though. @yuval-k

@marcogschmidt
Copy link
Contributor Author

@EItanya It's via the request_headers_to_add, request_headers_to_remove, etc. properties on the Envoy route see here, which are supported for DirectResponseActions (see link in PR description). Have also tested this manually.

@marcogschmidt marcogschmidt mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcogschmidt marcogschmidt

Labels
Area: Envoy activities related to envoy proxy Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EItanya @marcogschmidt