Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knative: support ingressClass annotation #2040

Closed
ilackarms opened this issue Dec 23, 2019 · 3 comments · Fixed by #2046
Closed

knative: support ingressClass annotation #2040

ilackarms opened this issue Dec 23, 2019 · 3 comments · Fixed by #2046
Assignees

Comments

@ilackarms
Copy link
Member

currently Gloo's Knative controller processes all ingresses.networking.internal.knative.dev, ignoring the user's custom ingress class defined here: https://github.com/knative/serving/blob/master/config/config-network.yaml#L89

With the addition of new conformance tests to knative (knative/serving#6305), Gloo should support filtering ingresses based on the networking.knative.dev/ingress.class annotation (with backwards-compatibility for users who do not currently rely on the annotation).

See https://github.com/knative/serving/blob/604bdd3afc450e9b74cb648bf4f2367898553296/pkg/apis/networking/register.go#L36 for definition in Knative

@ilackarms
Copy link
Member Author

networking.knative.dev/ingress.class=gloo.ingress.networking.knative.dev is the expected annotation

@ilackarms
Copy link
Member Author

in order to provide backwards compatibility, we need to provide a setting to toggle this behavior.

installing Knative will also require additional configuration step for users to configure knative's network-config to use gloo as its ingress provider

Gloo and Knative installation docs (as well as glooctl) will need to be updated in accordance with the new install step.

@ilackarms
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant