Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set a default so that eds warms up by default #2673

Closed
kdorosh opened this issue Mar 26, 2020 · 0 comments · Fixed by #2347
Closed

set a default so that eds warms up by default #2673

kdorosh opened this issue Mar 26, 2020 · 0 comments · Fixed by #2347

Comments

@kdorosh
Copy link
Contributor

kdorosh commented Mar 26, 2020

Gloo Endpoints warming timeout currently reads as:

	// Timeout to get initial snapshot of resources. If not set, Gloo will not wait for initial
	// snapshot - if set and and gloo could not fetch it's initial snapshot before the timeout
	// reached, gloo will panic.

We should change this to have a default of one minute. If set to 0s, then Gloo will not wait for the initial snapshot, as the previous default defines.

This will help reduce any potential downtime in upgrades with the default settings because Gloo will wait for EDS to sync before configuring Envoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant