Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loadBalancerIP in ingress-proxy service configurable #3184

Closed
maxbischoff opened this issue Jun 19, 2020 · 2 comments · Fixed by #3183
Closed

Make loadBalancerIP in ingress-proxy service configurable #3184

maxbischoff opened this issue Jun 19, 2020 · 2 comments · Fixed by #3183
Labels
Type: Enhancement New feature or request

Comments

@maxbischoff
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When configuring Gloo ingress using helm, I was missing a way to configure the loadBalancerIP for my ingress-proxy service.

Describe the solution you'd like
I would like the ability to provide a helm value for setting the loadBalancerIP of the ingress-proxy service.

Describe alternatives you've considered
I have considered https://docs.solo.io/gloo/latest/installation/gateway/kubernetes/helm_advanced/ but felt that the loadBalancerIP is a non-advanced setting for a ingress controller.
@maxbischoff maxbischoff added the Type: Enhancement New feature or request label Jun 19, 2020
@maxbischoff maxbischoff mentioned this issue Jun 19, 2020
Merged
8 tasks
@maxbischoff
Copy link
Contributor Author

maxbischoff commented Jun 19, 2020 •
edited

If you agree that this is a valid feature request I'll gladly finish my PR.

@kdorosh
Copy link
Contributor

kdorosh commented Jun 19, 2020

This is a valid feature request, would love a PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make loadBalancerIP in ingress-proxy service configurable
2 participants
@kdorosh @maxbischoff