invalid virtual service causes entire gateway to be invalidated

[ilackarms]

auth configuration is provided on the VirtualService level. When the virtual service has an invalid auth config, the following line reports an error on the Gateway (not the VS):

gloo/projects/gloo/pkg/translator/listener.go

Line 135 in 69867d0

validation.AppendHTTPListenerError(

This causes the VS to be improperly reported as "accepted", while the Gateway will be reported with an error (and stripped from the resulting Proxy). This means that a single invalid VS can take down an entire gateway which serves multiple VirtaulServices

We should report the error to the VirtualService, not the Gateway

[ilackarms]

for context: i came across this bug when working on developer portal. i created a VirtualService with a pointer to an AuthConfig which didn't exist. I noticed that the generated Proxy did not contain the virtualservice (which was marked accepted) or the gateway (listener) which was supposed to capture the virtual service. i ran gloo locally and discovered the gateway was being trimmed from the proxy by validation, which was reporting an error on the gateway rather than the virtualservice