Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose max_direct_response_body_size_bytes in Gloo #4560

Closed
cmwylie19 opened this issue Apr 6, 2021 · 0 comments · Fixed by #4674
Closed

Expose max_direct_response_body_size_bytes in Gloo #4560

cmwylie19 opened this issue Apr 6, 2021 · 0 comments · Fixed by #4674
Assignees
Labels
Type: Enhancement New feature or request

Comments

@cmwylie19
Copy link
Contributor

cmwylie19 commented Apr 6, 2021

Is your feature request related to a problem? Please describe.
A prospect is running into an error with the DirectResponse action when trying to mock some API response that return xml, and that is when the error shows up in the logs maximum is 4096.

The virtual service looks like this:

apiVersion: gateway.solo.io/v1
kind: VirtualService
metadata:
  name: mock-api
  namespace: gloo-system
spec:
  virtualHost:
    domains:
      - 'mock-api.services.yardstik.com'
    routes:
      - matchers:
         - prefix: /
        directResponseAction:
          status: 200
          body: |
            <?xml version="1.0"?>
            <GREATER THAN 4096 XML HERE>

The error does not occur when the payload is less than 4096.

Describe the solution you'd like
Would like to expose envoy's max_direct_response_body_size_bytes for Gloo Edge on the VirtualService.

Link to doc max_direct_response_body_size_bytes

Describe alternatives you've considered
As an alternative solution, we have tried setting perConnectionBufferLimitBytes on the upstream and the gateway-proxy

spec:
  connectionConfig:
    perConnectionBufferLimitBytes: 6000000
spec:
  options:
      perConnectionBufferLimitBytes: 6000000

Even after doing this, the logs still show the error: maximum is 4096

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants