Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide go type for solo apis #5531

Closed
asayah opened this issue Nov 2, 2021 · 4 comments
Closed

provide go type for solo apis #5531

asayah opened this issue Nov 2, 2021 · 4 comments
Labels
Type: Enhancement New feature or request

Comments

@asayah
Copy link
Contributor

asayah commented Nov 2, 2021

something similar too: https://github.com/jetstack/cert-manager/tree/master/pkg/apis/certmanager/v1

@asayah asayah added the Type: Enhancement New feature or request label Nov 2, 2021
@asayah asayah closed this as completed Nov 2, 2021
@jwilner
Copy link
Contributor

jwilner commented Nov 3, 2021

Just pointing out that you have Go types for some of your CRDs (the link there is just for some core ones), but a lot of them you don't. I was specifically looking for a FederatedVirtualService type which implements runtime.Object, which doesn't exist -- although the proto-gen type FederatedVirtualServiceSpec does.

@sam-heilbron
Copy link
Contributor

@jwilner have you seen solo-io/solo-apis#106? Can you let me know if the changes introduced to resolve that issue cover your use case?

@jwilner
Copy link
Contributor

jwilner commented Nov 3, 2021

@sam-heilbron those changes look great -- definitely the types I need -- but I'm hitting a lot of grief with dependencies trying to pull them in -- stuff like:

	github.com/solo-io/solo-apis/pkg/api/fed.gateway.solo.io/v1 imports
	k8s.io/client-go/kubernetes/scheme imports
	k8s.io/api/admissionregistration/v1alpha1: module k8s.io/api@latest found (v0.22.3), but does not contain package k8s.io/api/admissionregistration/v1alpha1

Or

	github.com/solo-io/solo-apis/pkg/api/fed.gateway.solo.io/v1 imports
	sigs.k8s.io/controller-runtime/pkg/client imports
	k8s.io/client-go/metadata: package k8s.io/client-go/metadata provided by k8s.io/client-go at latest version v0.22.3 but not at required version v8.0.0+incompatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants