Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more configuration params for upstreams #668

Closed
benishak opened this issue Apr 8, 2019 · 5 comments
Closed

allow more configuration params for upstreams #668

benishak opened this issue Apr 8, 2019 · 5 comments
Labels
Size: M 3 - 5 days Type: Enhancement New feature or request

Comments

@benishak
Copy link

benishak commented Apr 8, 2019

  • max_requests_per_connection
  • connect_timeout
  • upstream_connection_options
  • health_checks

https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto

@yuval-k
Copy link
Member

yuval-k commented Apr 8, 2019

the main thing here is allowing health_checks which is a pretty complicated data structure.
I need to figure out if we can 'passthrough' the envoy definition instead of redefining it as I don't think we can provided a better abstraction anyway.

@yuval-k yuval-k added the Type: Enhancement New feature or request label Apr 8, 2019
@benishak
Copy link
Author

benishak commented Apr 8, 2019

it is okay to adf health check in later stage
does gloo register only ready pods to envoy?

@yuval-k
Copy link
Member

yuval-k commented Apr 9, 2019

Today gloo works by taking the Endpoints object of a Service (i.e. what ever is in kubectl get endpoints SERVICE_NAME -o yaml)
I think I can do the non health check stuff in a day or two (have to clear some other things off my plate).

@ilevine
Copy link
Member

ilevine commented Jul 16, 2019

health checks is the only one remaining

@rickducott
Copy link

Most of this is done. The health check also appears to be worked on in another repo. Going to close this out as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: M 3 - 5 days Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants