Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get off of controller-runtime fork #8543

Closed
sheidkamp opened this issue Aug 7, 2023 · 2 comments
Closed

Get off of controller-runtime fork #8543

sheidkamp opened this issue Aug 7, 2023 · 2 comments
Assignees
Labels
release/1.15 Size: XS 1 day or less Type: Enhancement New feature or request

Comments

@sheidkamp
Copy link
Contributor

Gloo Edge Product

Open Source

Gloo Edge Version

v1.15

Is your feature request related to a problem? Please describe.

As part of the k8s 1.27 upgrade we had to create a fork to fix a bug that was keeping us from releasing.

This issue is to track the efforts to get that bugfix merged in the upstream and update our dependencies to return to a public controller-runtime release.

Describe the solution you'd like

  • Bug fix merged and backported to controller-runtime v1.15.x
  • solo-projects and ext-auth-service updated to use the released version
    • make sure other released changes are safe for merge

Describe alternatives you've considered

No response

Additional Context

PR with fix for main branch in upstream: kubernetes-sigs/controller-runtime#2438

Local fork: https://github.com/solo-io/controller-runtime

@sheidkamp sheidkamp added the Type: Enhancement New feature or request label Aug 7, 2023
@sheidkamp
Copy link
Contributor Author

Fix is now in controller-runtime v0.15 branch: kubernetes-sigs/controller-runtime#2443

@sheidkamp
Copy link
Contributor Author

In v1.15.0-rc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/1.15 Size: XS 1 day or less Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants