Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distroless #8849

Closed
nfuden opened this issue Oct 30, 2023 · 7 comments
Closed

Distroless #8849

nfuden opened this issue Oct 30, 2023 · 7 comments
Assignees
Labels
Committed: 1.18 Prioritized Indicating issue prioritized to be worked on in RFE stream Priority: Blocker Blocking users now Type: Enhancement New feature or request

Comments

@nfuden
Copy link
Contributor

nfuden commented Oct 30, 2023

Gloo Edge Product

Open Source

Gloo Edge Version

1.15.x

Is your feature request related to a problem? Please describe.

Alpine is no longer supported for our purposes so we moved to ubuntu to mimic upstream and decided to hold off at the time on adding a distroless build. Turns out some of the libraries in the image used by upstream are include some packages we dont want to have around.

Describe the solution you'd like

Get a distroless option for those who dont want full ubuntu shenanagins

This SHOULD be an opt in version for both non-fips and fips. This does NOT need the debug images to be supported.
This MUST be toggleable as part of the top level helm configuration rather than a per deployment flag.
Our distroless SHOULD use most of the same work flow as our ubuntu versions
This MAY include our apiserver components but it MAY leave that to a future issue.
Distroless MUST be supported for gloo, discovery, envoy-gloo-ee-wrapper, extauth, and rate limit servers.
Distroless images MUST NOT include any problematic licenses such as those found but not used in ubuntu images.

Describe alternatives you've considered

No response

Additional Context

No response

┆Issue is synchronized with this Asana task by Unito

@nfuden nfuden added Type: Enhancement New feature or request Priority: Blocker Blocking users now labels Oct 30, 2023
@nfuden nfuden self-assigned this Oct 30, 2023
@sam-heilbron
Copy link
Contributor

We no longer consider this a release blocker for 1.16. This is intended to be released in a subsequent patch release. Confirmed with @SantoDE

@sam-heilbron
Copy link
Contributor

sam-heilbron commented Dec 12, 2023

#6084 is a duplicate issue. I am closing that one, in favor of this more recently created issue, but I wanted to keep the context

@sam-heilbron
Copy link
Contributor

Definition of done:

  • For 1.17, we will publish distroless variants of our images, in addition, to our existing images.
  • We will make it possible in the Helm chart to define that distroless variants should be used
  • We will provide user facing documentation around this functionality
  • We will work with the field to enable adoption

@DuncanDoyle DuncanDoyle added RFE and removed RFE labels Mar 4, 2024
@htpvu htpvu added the Prioritized Indicating issue prioritized to be worked on in RFE stream label Mar 6, 2024
@davidjumani
Copy link
Contributor

List of problematic libraries that should not be included are :

  • berkleydb

@davidjumani
Copy link
Contributor

The following images now have a distroless variant :

  • caching-ee
  • discovery-ee
  • discovery-ee-fips
  • ext-auth-plugins
  • extauth-ee
  • extauth-ee-fips
  • gloo-ee
  • gloo-ee-envoy-wrapper
  • gloo-ee-envoy-wrapper-fips
  • gloo-ee-fips
  • observability-ee
  • rate-limit-ee
  • rate-limit-ee-fips
  • sds-ee
  • sds-ee-fips

Having discussed on slack, have decided to :

  • Add support for fed images

@davidjumani
Copy link
Contributor

Adding distroless variants to all images created by gloo edge in #9278

@davidjumani
Copy link
Contributor

This will be in v1.17.0
Distroless images can be specified via the helm value global.image.variant to distroless or fips-distroless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Committed: 1.18 Prioritized Indicating issue prioritized to be worked on in RFE stream Priority: Blocker Blocking users now Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants