Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Grafana queries by adding multi-cluster support to distinguish between installed environments #9016

Closed
totallyGreg opened this issue Dec 22, 2023 · 2 comments
Labels
Type: Enhancement New feature or request zendesk

Comments

@totallyGreg
Copy link
Contributor

Gloo Edge Product

Enterprise

Gloo Edge Version

v1.15.7

Is your feature request related to a problem? Please describe.

Customer has installed edge in multiple environments and is using a single external Grafana server. Metrics from each of these servers are aggregated from each of these environments but since there is no way to distinguish where the metrics came from they are all displayed together.

In order to view these separate it is necessary to hand edit the configmaps glooe-grafana-custom-dashboards-v2 and gloo-observability-configby addingcluster=cmedev`

e.g. changing:

"expr": "glooe_solo_io_xds_insync{gloo=\"gloo\", namespace=\"$namespace\", resource=\"type.googleapis.com/envoy.config.listener.v3.Listener\"}"

to:

"expr": "glooe_solo_io_xds_insync{cluster=\"cmedev\", gloo=\"gloo\", namespace=\"$namespace\", resource=\"type.googleapis.com/envoy.config.listener.v3.Listener\"}"

This is tedious and causes problems on upgrade.

{"level":"warn","ts":"2023-12-15T21:59:14.055Z","logger":"observability.v1.event_loop.observability","caller":"syncer/default_dashboards.go:33","msg":"failed to save default dashboard to grafana: envoy: 412 The dashboard has been changed by someone else","version":"1.15.7"}

Describe the solution you'd like

Support multi-cluster in the generated dashboards.

Describe alternatives you've considered

No response

Additional Context

No response

@totallyGreg totallyGreg added the Type: Enhancement New feature or request label Dec 22, 2023
@soloio-bot
Copy link

Zendesk ticket #3040 has been linked to this issue.

@davidjumani
Copy link
Contributor

davidjumani commented Jan 23, 2024

The new feature introduces a new observability option extraMetricQueryParameters : Specifies extra query parameters to add to all metric query definitions in the Grafana dashboards generated by gloo

gloo:
  settings:
    observabilityOptions:
      grafanaIntegration:
        extraMetricQueryParameters: gateway_proxy_id="rand\"
Screenshot 2024-01-17 at 9 55 04 AM

This will be in v1.17.0-beta1, v1.16.1 and v1.15.12 when released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request zendesk
Projects
None yet
Development

No branches or pull requests

3 participants