grpcJsonTranscoder Upstream is causing all the Routes to be on a warning state

[edubonifs]

Gloo Edge Product

Open Source

Gloo Edge Version

1.15.x

Kubernetes Version

1.26

Describe the bug

If we apply an Upstream with grpcJsonTranscoder, every RouteTable will report a Warning state:

status:
  statuses:
    gloo-system:
      reportedBy: gloo
      state: Accepted
      subresourceStatuses:
        '*v1.Proxy.gateway-proxy_gloo-system':
          reason: "1 error occurred:\n\t* Route Error: ProcessingError. Reason: *grpcjson.plugin:
            invalid route. Route Name: service-route-0-matcher-0;
            Route Error: ProcessingError. Reason: *grpcjson.plugin: invalid route.
            Route Name: service-route-0-matcher-0;
            Route Error: ProcessingError. Reason: *grpcjson.plugin: invalid route.
            Route Name: service-route-0-matcher-0;
            Route Error: ProcessingError. Reason: *grpcjson.plugin: inv"
          reportedBy: gloo
          state: Rejected

Expected Behavior

It should not harm every RouteTable

Steps to reproduce the bug

Apply this Upstream
upstream.yaml.zip

Additional Environment Detail

No response

Additional Context

No response

┆Issue is synchronized with this Asana task by Unito

[DuncanDoyle]

Do we happen to have a full reproducer of this one? I tried to apply the attached upstream.yaml to my GE 1.15.14 instance, but I didn't observe any errors .... Would be useful to have:

• K8S service (targeted by the Upstream)
• RouteTable
• VirtualService
• etc.

[DuncanDoyle]

Full reproducer here (instructions in README): https://github.com/DuncanDoyle/ge-gloo-9160

[DuncanDoyle]

Seems this issue started happening in Gloo Edge 1.14.3 ...... I can't reproduce it in 1.14.2 and lower .....

[sam-heilbron]

See: #7477 (comment)

This seems all related to https://github.com/solo-io/gloo/milestone/40?closed=1

[nfuden]

Discovered so far:
The error we are seeing is coming from
https://github.com/solo-io/gloo/blob/v1.14.x/projects/gloo/pkg/plugins/grpcjson/plugin.go#L146
Which for whatever reason is not correctly detecting that the routeaction is of type single: https://github.com/solo-io/gloo/blob/v1.14.x/projects/gloo/pkg/plugins/pluginutils/destination_upstreams.go#L35

This starts occuring due to this 1.14 backport which attempted to make migration from old to new apis seemless 7845a04

This backport makes it easier to comingle the two options and have a clean cut over but something about the case we are seeing is leading to these erroneous warning messages being spewed.

[davidjumani]

This issue only arises when any route defined on the listener is not a routeAction (eg: redirectAction, directResponseAction). The plugin code expects / only supports a routeAction. If any other type of route is passed, it results in a nil routeAction that in turn results in the observed error. In the steps to reproduce this, the new VS uses a redirect action route that leads this issue.
A simple fix can be to log that the plugin can not work on any other type of route rather than return an error. While this does not solve the overarching issue, it is a quick stopgap to unblock the user

I've created a PR for the fix here

[davidjumani]

This fix will be in 1.17.0-beta1, v1.16.11 and v1.15.26 when released

[nfuden]

v1.15.18 and v1.16.9