Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube2e_test env variable is slow. Should use labels #9225

Open
nfuden opened this issue Mar 6, 2024 · 1 comment
Open

Kube2e_test env variable is slow. Should use labels #9225

nfuden opened this issue Mar 6, 2024 · 1 comment

Comments

@nfuden
Copy link
Contributor

nfuden commented Mar 6, 2024

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

Today it can take 5-> 10 minutes to build a spec tree for our tests. In ci we mainly run tests in parallel runners via toggling whether we should skip them.

The way we evaluate this means we compile alot more of the go code than needed when running a single kube2e_test type.

Describe the solution you'd like

Dont use os.env to drive what to run. Use ginkgo labels to reduce spec build time.

Additional Context

No response

@sam-heilbron
Copy link
Contributor

In #7067 we removed the usage of kube2e_test env variable in the test. Instead we just invoke the specific suite directly: https://github.com/solo-io/gloo/blob/main/Makefile#L209.

I imagine there are more improvements we can do to test filtering in general, we started this with https://github.com/solo-io/gloo/blob/main/Makefile#L190.

Can you help me understand what changes you'd like to see for the kube2e tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants