Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflect.DeepEqual no longer works for golang/protobuf v1.4.x in-memory proto objects #180

Closed
harveyxia opened this issue Dec 7, 2020 · 0 comments · Fixed by #181
Closed

reflect.DeepEqual no longer works for golang/protobuf v1.4.x in-memory proto objects #180

harveyxia opened this issue Dec 7, 2020 · 0 comments · Fixed by #181

Comments

@harveyxia
Copy link
Contributor

harveyxia commented Dec 7, 2020 •
edited

Moving from golang/protobuf v1.3.x to v1.4.x, in-memory representations of proto objects contain additional internal state (a new atomicMessageInfo field) that prevents reflect.DeepEqual from working reliably on two identical objects.

Additional references:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix object equality for protos solo-io/skv2
1 participant
@harveyxia