New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: make_credential() takes 2 positional arguments but 4 were given #52
Comments
|
I'll fix this. |
I can't reproduce. What versions of solo-python and Yubico/python-fido2 do you have installed @patvdleer? |
Having the same issue, solo version output: |
Im on latest master |
I'm asking about the fido2 dependency, can you tell? |
Same issue here with a freshly created venv: $ python3 --version
Python 3.7.6
$ pip list
Package Version
------------ ----------
certifi 2019.11.28
cffi 1.13.2
chardet 3.0.4
Click 7.0
cryptography 2.8
ecdsa 0.15
fido2 0.8.1
idna 2.8
intelhex 2.2.1
pip 19.3.1
pycparser 2.19
pyserial 3.4
pyusb 1.0.2
requests 2.22.0
setuptools 41.2.0
six 1.13.0
solo-python 0.0.21
urllib3 1.25.7 |
|
I see now. Can you try v0.0.22 please? |
@nickray 0.0.22 works for me. Thanks! |
Thank heavens... |
Confirming, thanks for the super fast fix |
@nickray not sure if this is related, but some commands that used to work before are now raising an AttributeError:
|
Oh jeez, this is utterly annoying. Pulling in the fido2 breaking changes in 0.8 did in fact break things :/ New round, new luck, v0.0.23 is out. |
Tried a few operations with v0.0.23: looks fine now. |
@patvdleer can you check and close if appropriate? Thanks. |
The text was updated successfully, but these errors were encountered: