Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: PicCard: animation will be triggered earlier than loading of picture. #11

Closed
solring opened this issue Nov 6, 2021 · 3 comments
Closed

bug: PicCard: animation will be triggered earlier than loading of picture. #11

solring opened this issue Nov 6, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@solring
Copy link
Owner

solring commented Nov 6, 2021

Should use onLoad to launch animation.
@solring solring added the bug Something isn't working label Nov 6, 2021
@solring
Copy link
Owner Author

solring commented Nov 6, 2021

https://www.react-reveal.com/docs/when/

@solring
Copy link
Owner Author

solring commented Nov 7, 2021 •
edited
Loading

c178f73
Currently use image onload event handler to detect the load event to trigger animation.
But since the images are large (no thumbnails), images will appear one by one, which is also kind of weird.

Cannot use window.onload handler currently because images are fetched afterwards.

@solring
Copy link
Owner Author

solring commented Nov 7, 2021

#8 may resolve this as well.

@solring solring closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solring