Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mutability gap: do not allow shared mutation when creating frozen reference #557

Merged
merged 4 commits into from Dec 3, 2018

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 2, 2018

Waits for rust-lang/rust#56161 to land

@RalfJung RalfJung added S-blocked-on-rust Status: Blocked on landing a Rust PR S-waiting-on-review Status: Waiting for a review to complete labels Dec 2, 2018
@RalfJung RalfJung removed the S-blocked-on-rust Status: Blocked on landing a Rust PR label Dec 2, 2018
@RalfJung
Copy link
Member Author

RalfJung commented Dec 2, 2018

With rust-lang/rust#56165 landed, I think it makes sense to merge this in miri and just disable the VecDeque tests until rust-lang/rust#56161 lands. That way I can be sure that when I work on other changes in Stacked Borrows, that is not incompatible with this change.

So this is ready for review.

Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit

src/stacked_borrows.rs Outdated Show resolved Hide resolved
@RalfJung RalfJung removed the S-waiting-on-review Status: Waiting for a review to complete label Dec 3, 2018
@RalfJung RalfJung merged commit 5bde40c into rust-lang:master Dec 3, 2018
@RalfJung RalfJung deleted the fix-mutability-gap branch December 13, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants