Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zipped KO-files #13

Open
philmmanjaro opened this issue Feb 24, 2018 · 3 comments
Open

Add support for zipped KO-files #13

philmmanjaro opened this issue Feb 24, 2018 · 3 comments

Comments

@philmmanjaro
Copy link

On some Distributions like Manjaro KO-files might be zipped to save space. Currenlty LDM doesn't support this:

mkmodaliases linux415-nvidia /usr/lib/modules/extramodules-4.15-MANJARO/nvidia.ko.gz
File does not appear to be a kernel module: /usr/lib/modules/extramodules-4.15-MANJARO/nvidia.ko.gz

On our end we use cmds like gzip "${pkgdir}/usr/lib/modules/${_extramodules}/"*.ko

@ikeydoherty
Copy link
Member

Ah thats interesting - is this currently the only format you're using? Or other compression formats?

Basically I'm wondering whether a cheap suffix check is enough or I should explicitly check the mimetype and attempt to use zlib or whether libarchive is needed

@ikeydoherty
Copy link
Member

BTW I should point out that the one problematic package for mkmodaliases at this point is the NVIDIA set, per the README. We might need to teach it how to deal with those nuances so that we can drop the custom scripts we all use derived from Jockey modaliases world

@philmmanjaro
Copy link
Author

Well, after looking into your scripts I found out that you created those modealiases during package creation. We can use the same, even the Jockey modaliases format. So this is totally optional. On installed systems most of the KO-files are zipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants