New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTABUG: Cloning of submodules via HTTPS instead of SSH #2

Closed
L0g4n opened this Issue Mar 23, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@L0g4n

L0g4n commented Mar 23, 2018

Hi,

in your README you say to clone the repo use the following command git clone --recursive https://github.com/solutionroute/hugo-smorg.git. So git tries to clone the submodules you have in .gitmodules but the repos you listed there are cloned via SSH, but fails of course then for me because i get permissions errors.

EDIT: Sorry, this is of course not a bug, i forgot that i only had my gitlab SSH key in my ssh-agent added and not my github SSH key 🤦‍♂️ . Still for simply cloning it would may be better to just clone via SSH because for 3rd party repos you do not have permission to write anyway. So you actually have no advantage from using SSH.

@L0g4n L0g4n changed the title from Recursive cloning fails to NOTABUG: Cloning of submodules via HTTPS instead of SSH Mar 23, 2018

@solutionroute

This comment has been minimized.

Owner

solutionroute commented Mar 26, 2018

Hi, sorry for the delay in replying.

I will update the submodules to use HTTPS; even those that I author - thank you so much for bringing this to my attention!

@solutionroute

This comment has been minimized.

Owner

solutionroute commented Mar 26, 2018

Updated and tests ok on my side, thanks again for the heads up. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment