Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

NOTABUG: Cloning of submodules via HTTPS instead of SSH #2

Closed
L0g4n opened this issue Mar 23, 2018 · 2 comments
Closed

NOTABUG: Cloning of submodules via HTTPS instead of SSH #2

L0g4n opened this issue Mar 23, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@L0g4n
Copy link

L0g4n commented Mar 23, 2018

Hi,

in your README you say to clone the repo use the following command git clone --recursive https://github.com/solutionroute/hugo-smorg.git. So git tries to clone the submodules you have in .gitmodules but the repos you listed there are cloned via SSH, but fails of course then for me because i get permissions errors.

EDIT: Sorry, this is of course not a bug, i forgot that i only had my gitlab SSH key in my ssh-agent added and not my github SSH key 🤦‍♂️ . Still for simply cloning it would may be better to just clone via SSH because for 3rd party repos you do not have permission to write anyway. So you actually have no advantage from using SSH.

@L0g4n L0g4n changed the title Recursive cloning fails NOTABUG: Cloning of submodules via HTTPS instead of SSH Mar 23, 2018
@mwyvr
Copy link
Owner

mwyvr commented Mar 26, 2018

Hi, sorry for the delay in replying.

I will update the submodules to use HTTPS; even those that I author - thank you so much for bringing this to my attention!

@mwyvr
Copy link
Owner

mwyvr commented Mar 26, 2018

Updated and tests ok on my side, thanks again for the heads up. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants