Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid return type of cssVariables function #5

Merged
merged 4 commits into from May 10, 2022
Merged

fix: invalid return type of cssVariables function #5

merged 4 commits into from May 10, 2022

Conversation

RanolP
Copy link
Contributor

@RanolP RanolP commented May 10, 2022

closes #4

기존 타이핑에서 실제 값과 타입이 다른 문제를 해결합니다.
복잡한 타입이 활용됨에 따라 컴파일 시간이나 에디터 반응 속도에 악영향을 미칠 수 있으므로 단순화된 `--solvedac-${string}`도 고려해보았으나, 기존 코드의 목적이 타입 정확성에 가까운 것으로 보여 기존 목적에 부합하게 고쳤습니다.

src/utils/styles.ts Outdated Show resolved Hide resolved
Copy link
Member

@shiftpsh shiftpsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value 타이핑을 이렇게 할 수도 있군요, 기여 감사합니다!

Copy link
Member

@shiftpsh shiftpsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 감사합니다. 덕분에 개발이 더 수월해질 것 같습니다!

@shiftpsh shiftpsh merged commit 8122d3a into solved-ac:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cssVariables의 반환 타입이 올바르지 않습니다.
2 participants