Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, macOS: update action to use "notarytool" instead of "altool" #1407

Closed
ruevs opened this issue Sep 13, 2023 · 4 comments · Fixed by #1408
Closed

CI, macOS: update action to use "notarytool" instead of "altool" #1407

ruevs opened this issue Sep 13, 2023 · 4 comments · Fixed by #1408
Assignees

Comments

@ruevs
Copy link
Member

ruevs commented Sep 13, 2023

System information

Update needed to the macOS signing script

The GitHub action building the "edge" version of SolveSpace in the "Build Release macOS", on the "Sign Build" step gives a warning about altool being deprecated and advises that a new "notarytool" should be used to sign the software.

2023-09-12 20:06:52.704 *** Warning: altool has been deprecated for notarization and starting in late 2023 will no longer be supported by the Apple notary service. You should start using notarytool to notarize your software. (-1030)

sign-macos.sh should be updated to use this "notarytool".

Additional information

#1400 (comment)

@ruevs ruevs changed the title CI, macOS: update action to use no instead of altool CI, macOS: update action to use "notarytool" instead of "altool" Sep 13, 2023
@phkahler phkahler linked a pull request Sep 23, 2023 that will close this issue
@ruevs
Copy link
Member Author

ruevs commented Apr 17, 2024

#1408 (comment)

@ruevs
Copy link
Member Author

ruevs commented Apr 17, 2024

@vespakoen Naaah it did not work. And the build time became 24m55s (from 12m1s before) - it builds everything twice ;-(
https://github.com/solvespace/solvespace/actions/runs/8727893435/job/23946718599

@ruevs ruevs reopened this Apr 17, 2024
@vespakoen
Copy link
Contributor

I see this:

Error: HTTP status code: 401. Invalid credentials. Username or password is incorrect. Use the app-specific password generated at appleid.apple.com. Ensure that all authentication arguments are correct.'

Maybe the password is not set correctly?

I can also generate a new one and send it to Jonathan so he can add it to the secrets.

I think it builds twice for different architectures? not sure why it's slower though.

I will try to find some time this week to look into it also look / try out the Qt stuff.

@vespakoen
Copy link
Contributor

Seemed to have been an issue with how it was retrieving the password from the environment variable. Fixed now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants