New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code in "applications" doesn't work; experiments not reproducible #5
Comments
I can confirm this. I even went through the repo's git history and couldn't find any working version. |
Apologies for the confusion! On the The manuscript branch includes implementations of the functions you are referencing (score_umls_ontologies, strip_affixes, umls_ontology_dicts, etc) and some scripts for applying labeling functions, training the label model, and training BioBERT. There is some complexity around initializing and using the UMLS in the older branch, since it assumes a parquet file has already been generated. In general, this branch isn't as polished as it should be, but it should be possible to reproduce the public NER results. Don't hesitate to spam Issues if you encounter other blockers. Thank you for your interest and questions!! |
Thanks Jason. I've tried the manuscript branch, but there is an error trying to reproduce the experiments in the scripts folder When running However, the "ontologies" folder in the shared GDrive folder (linked in the QuickStart section of Readme) does not contain any file called MEDNAME - nor does any GDrive subfolder - and neither is this file present in the github repo it seems Could you please share where to find MEDNAME (as well as any other dependencies or instructions required to reproduce the experiments in your manuscript? At a minimum, I'd love to be able to reproduce the i2b2 results...) Thanks a lot in advance! |
Similar issue when running Please let us know how to obtain the missing files (or, if it's easier, maybe do a bulk upload/share of the necessary files?) |
Since Please do share where nad how to obtain these files - thanks in advance |
Hi @tmadl, |
Let me know if you have additional problems! I'll close this issue for now, but happy to re-open. |
A lot of the imports in the scripts under the "applications" subfolder fail - for example:
from trove.utils import score_umls_ontologies
from trove.labelers.norm import lowercase, strip_affixes
This makes it impossible to reproduce the experiments in the paper
Could you please share these functions (or the previous version of the repo) to make the code runnable?
Thanks a lot in advance!
The text was updated successfully, but these errors were encountered: