Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashRouter(react-router-dom v4) and scrollchor #29

Closed
jacktang opened this issue May 12, 2018 · 1 comment
Closed

HashRouter(react-router-dom v4) and scrollchor #29

jacktang opened this issue May 12, 2018 · 1 comment

Comments

@jacktang
Copy link

Hello,

I use HashRouter in my react app and the landing page is single-page which use react-scrollchor component to scroll to some section with animation. Say I defined #service section in the landing page, when I click Service and the page scroll to the anchor and finally the URL turn to /#/service(should be /#service), the page is blank. And I leave the example page here

I searched stackover and find https://github.com/rafrex/react-router-hash-link would work, and could you support HashRouter in scrollchor?

Thanks!

@bySabi
Copy link
Collaborator

bySabi commented Jun 4, 2018

It seems you could solve it on example page. The landing page is great, good job!

I don't use HashRouter my self but you can do smooth scrolling with it.

Feel free to reopen this issue is you needed.

@bySabi bySabi closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants