[aws][fix] Fetch public ECR repositories are global (#1874)

someengineering · Jan 10, 2024 · 4725be5 · 4725be5
1 parent 35fc7f6
commit 4725be5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/plugins/aws/resoto_plugin_aws/collector.py b/plugins/aws/resoto_plugin_aws/collector.py
@@ -62,6 +62,7 @@
 global_resources: List[Type[AwsResource]] = (
     cloudfront.resources
     + dynamodb.global_resources
+    + ecr.global_resources
     + iam.resources
     + route53.resources
     + s3.resources

diff --git a/plugins/aws/resoto_plugin_aws/resource/ecr.py b/plugins/aws/resoto_plugin_aws/resource/ecr.py
@@ -85,8 +85,10 @@ def collect(visibility: str, spec: AwsApiSpec) -> None:
                 raise
 
         # collect private and public repositories
-        collect("private", cls.api_spec)
-        collect("public", cls.public_spec)
+        if builder.region.name == "global":
+            collect("public", cls.public_spec)
+        else:
+            collect("private", cls.api_spec)
 
     @classmethod
     def called_collect_apis(cls) -> List[AwsApiSpec]:
@@ -123,3 +125,4 @@ def called_collect_apis(cls) -> List[AwsApiSpec]:
 
 
 resources: List[Type[AwsResource]] = [AwsEcrRepository]
+global_resources: List[Type[AwsResource]] = [AwsEcrRepository]