Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotocore][feat] Outer edge collection support - Part 1/4 #877

Merged
merged 7 commits into from May 19, 2022

Conversation

meln1k
Copy link
Member

@meln1k meln1k commented May 19, 2022

Description

First out of 4 PR to support outer edge collection:

  • Resotocore has a new collect workflow step
  • Resotocore saves the outer edges during the merge api call
  • Resotocore is able to link the outer edges
  • Resotoworker sends the outer edges for the AWS and K8S plugins

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox
  • Document new or updated functionality (someengineering/resoto.com#XXXX)

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@meln1k meln1k changed the title [resoto][feat] Outer edge collection support - Part 1/4 [resotocore][feat] Outer edge collection support - Part 1/4 May 19, 2022
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please find my comments.

@meln1k meln1k force-pushed the nm/resoto-outer-edge-handler branch from ef7b3f9 to d9b7eb4 Compare May 19, 2022 16:45
@codecov-commenter
Copy link

Codecov Report

Merging #877 (9f0fa49) into main (d53b757) will increase coverage by 0.13%.
The diff coverage is 98.55%.

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   89.78%   89.91%   +0.13%     
==========================================
  Files          69       70       +1     
  Lines       10060    10108      +48     
==========================================
+ Hits         9032     9089      +57     
+ Misses       1028     1019       -9     
Flag Coverage Δ
resotocore 89.91% <98.55%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tocore/action_handlers/merge_outer_edge_handler.py 97.50% <97.50%> (ø)
resotocore/resotocore/__main__.py 89.17% <100.00%> (+0.28%) ⬆️
resotocore/resotocore/cli/command.py 87.78% <100.00%> (+<0.01%) ⬆️
resotocore/resotocore/db/runningtaskdb.py 96.15% <100.00%> (ø)
resotocore/resotocore/message_bus.py 97.41% <100.00%> (+0.02%) ⬆️
resotocore/resotocore/task/__init__.py 72.72% <100.00%> (ø)
resotocore/resotocore/task/task_description.py 91.55% <100.00%> (+0.02%) ⬆️
resotocore/resotocore/task/task_handler.py 88.01% <100.00%> (+0.31%) ⬆️
resotocore/resotocore/util.py 95.86% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53b757...9f0fa49. Read the comment docs.

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@meln1k meln1k merged commit 9bc4086 into main May 19, 2022
@meln1k meln1k deleted the nm/resoto-outer-edge-handler branch May 19, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants