Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize #81

Open
hyperrealgopher opened this issue May 3, 2020 · 4 comments
Open

Optimize #81

hyperrealgopher opened this issue May 3, 2020 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@hyperrealgopher
Copy link
Collaborator

See #47

Also here are some other notes:

Actually, Data.Text switch is great! Less memory hungry by a lot, roughly the same processor intensity. Processor crunching due to <> and un/pack'ing where not necessary. Should cache certain widgets and be careful about those operations/avoiding doing certain things every single update.

tl;dr: <> expensive also cache widgets so not do every time. However, caching widgets can be extremely memory-hungry, especially when menus are huge you'd need a smart way to not cache widgets that are out-of-view... might not even be worthwhile to cache them! May be able to think of a more sophisticated solution.

@hyperrealgopher hyperrealgopher added the enhancement New feature or request label May 3, 2020
@hyperrealgopher hyperrealgopher added this to the v0.1.0 milestone May 3, 2020
@hyperrealgopher
Copy link
Collaborator Author

Should just clean contents from the get-go and not do it every update!

@hyperrealgopher
Copy link
Collaborator Author

Some widgets COULD be cached into the representations, like text file contents!

@hyperrealgopher hyperrealgopher modified the milestones: v0.1.0, v0.2.0, v0.3.0, v0.4.0 May 3, 2020
@hyperrealgopher hyperrealgopher removed this from the v0.5.0 milestone May 17, 2020
@hyperrealgopher
Copy link
Collaborator Author

I just optimized text file viewing mode in v0.8.0

@hyperrealgopher
Copy link
Collaborator Author

benchmark, profile, optimize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant