Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLP is equivalent to a single linear layer #23

Open
YishGene opened this issue Mar 5, 2023 · 0 comments
Open

MLP is equivalent to a single linear layer #23

YishGene opened this issue Mar 5, 2023 · 0 comments

Comments

@YishGene
Copy link

YishGene commented Mar 5, 2023

One more issue - your implementation of MLP, in model.py, is just a bunch of stacked linear layers with no non-linearities between them. This is mathematically equivalent to just a linear layer with in_dim = dims[0] and out_dim=dims[-1].

Why not use the activation between the layers?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YishGene