Switch to using connector instead of collector
#358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molant
reviewed
Jul 4, 2017
| message: 'What collector do you want to use?', | ||
| name: 'collector', | ||
| choices: connectorKeys, | ||
| message: 'What connector do you want to use?', |
There was a problem hiding this comment.
We could improve already the question here and briefly explain what a connector is. Maybe add a description for each one? Something similar to:
What connector do you want to load the content of the website?
- cdp (you will need to have chrome installed)
- jsdom (will use jsdom, no additional installation required)
There was a problem hiding this comment.
That should be handled separately from this PR.
I've opened: #361.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #286
Fix #286