Fix: Call formats asynchronously
#880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvaje
reviewed
Mar 13, 2018
| if (hasError(reports)) { | ||
| endSpinner('fail'); | ||
| } else { | ||
| endSpinner('succeed'); | ||
| } | ||
|
|
||
| sonarwhal.formatters.forEach((formatter) => { | ||
| formatter.format(reports, target); | ||
| await each(sonarwhal.formatters, async (formatter) => { |
There was a problem hiding this comment.
why do you use the package async instead of use a for … of..?
There was a problem hiding this comment.
We should start using async in all places instead of for … of for legibility purposes and this was a good moment to start.
There was a problem hiding this comment.
Let's replace all the map, reduce, forEach, etc. for regular for loops then 😛
There was a problem hiding this comment.
It is not the same example, you don't need to add any extra package to do that.
There was a problem hiding this comment.
We are using lodash in parts of the code 🙄
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
There were some reports that Excel formatter was generating just an empty file. It turns out it's the first
formatterthat actually requires to be called asynchronously.This PR makes the call to
formatter.formatusingawait.