Controllers Should Not Be Referenced With Single Colon Syntax

[Selion05]

Feature Request

related to #5227 using '::' removes the deprecation notices
link

[OskarStark]

Would you like to provide a PR?

[valkars]

And also https://github.com/sonata-project/SonataAdminBundle/blob/3.x/src/Resources/config/routing/sonata_admin.xml#L4
Referencing controllers with FrameworkBundle:Redirect:redirect is deprecated since Symfony 4.1, use "Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction" instead.

[Selion05]

what about

SonataAdminBundle/src/Route/RouteCollection.php

Line 239 in 57a4e6d

if (false === strpos($this->baseControllerName, ':')) {

? should I change this line as well or will it break code for someone who doesn't use the default controller and use the odeprecated syntax?

[Selion05]

SonataAdminBundle/src/Command/GenerateAdminCommand.php

Lines 128 to 129 in 57a4e6d

	? sprintf('%s:%s', $bundle->getName(), substr($controllerClassBasename, 0, -10))
	: CRUDController::class

[phansys]

This issue was fixed by #5228.
Thank you!