Changed factoring-definition in DI to Symfony > 2.6 compatible syntax #993
Conversation
| @@ -17,7 +17,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "symfony/framework-bundle": "~2.3|~3.0", | |||
| "symfony/framework-bundle": "~2.6|~3.0", | |||
There was a problem hiding this comment.
Dropping sf < 2.6 support is huge BC-break
There was a problem hiding this comment.
Don't mind that comment, I probably did not see this was supposed to be major in the first place
|
Could you please rebase your PR and fix merge conflicts? |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
|
This is a valid major PR @fivetide can you please add the default Header? |
|
ping @fivetide |
I'm sorry but it is not. This could be done with a BC way. Closing this one. @fivetide A PR agains 3.x will be very welcome! 👍 |
ok |
factory-* syntax has been deprecated since Symfony 2.6, and removed in 3.0.
This PR fixes #987, and enables usage of SonataMediaBundle in Symfony >3.
Symfony <2.6 is not compatible anymore.
Credit goes to @LeoPelan, who posted this patch.