Update SwiftMailerConsumer.php

[red-smeg]

Add ability to set the returnPath for mail messages sent via the notificationBundle

Subject

I am targeting this branch, because the change is backward compatible and adds another email parameter setting option but does not affect if it is not submitted.

Closes #363

Changelog

### Changed

sendEmail function to allow for there setting of a return path 

[core23]

Please add at least one test

[red-smeg]

@core23 Hi was the request to add a test something you wanted me to do ? I am new to this so I'm honestly not sure what to do in that case. I would be happy to learn if someone would be happy to guide.

[OskarStark]

Sure thing

Please have a look at SwiftMailerConsumerTest, you can check cc for reference in the test and „copy and adjust“ this part.
I am on a phone right now and not sure if this test exists nor if cc is tested properly 😎🤔

Please don’t hesitate to ask if sth is unclear

[red-smeg]

I added a change to the swift mailer test

[red-smeg]

Can we check the test now ?

[greg0ire]

I cannot see any test in your PR.

[red-smeg]

I cannot see any test in your PR.

commit 0980e91

[greg0ire]

That's great but that commit is not part of your PR. I don't see it in the "Commits" tab.

[red-smeg]

That's great but that commit is not part of your PR. I don't see it in the "Commits" tab.

git hub says add commits by pushing to patch-1 branch. I did that this is my first PR I'm not sure what more I can do without making it more messy.

[greg0ire]

It does not look like you actually pushed that commit to the branch. What commands did you run?

[greg0ire]

Please fix the build

[red-smeg]

Please fix the build

Is that meant for me ? I honestly don't know how to do that or even why it failed those steps ? will gladly help if someone can explain what I need to do ?

[greg0ire]

Yes it is meant for you. See the "Some checks were not successful" section below? There are few things you need to fix. Luckily, it is not unit tests, just code style issues, you can fix them by running make cs-fix

[greg0ire]

Alternatively, you can wait for #367 to be merged, since the issues do not come from your changes, but from a php-cs-fixer upgrade. Sorry for this 🙏

[OskarStark]

I merged #367, can you please rebase?

[greg0ire]

I just did it for you @red-smeg :)

[red-smeg]

So did this get approved and incorporated ?

[greg0ire]

So did this get approved and incorporated ?

No, we cannot merge unless the build is green.

[red-smeg]

so what happens now. Looks approved do I close the PR or is that for whomever merges the change to do ?

[greg0ire]

Does this answer your question? 😄 Thanks @red-smeg !

[OskarStark]

Congratulations @red-smeg 🎉

[red-smeg]

thanks for the help