Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus 2.x] no boot delegation #11

Closed
wants to merge 20 commits into from
Closed

[nexus 2.x] no boot delegation #11

wants to merge 20 commits into from

Conversation

adreghiciu
Copy link

Replace Nexus 2 boot delegation "*" with packages being exported by system bundle and plugins using DynamicImport-Package.

This will allow plugins to include as dependencies different versions of libraries that are also present in nexus core.

@adreghiciu adreghiciu changed the title Nexus 2.x no boot delegation [nexus 2.x] no boot delegation Jul 13, 2016
@cstamas
Copy link

cstamas commented Jul 13, 2016

+1, locally tested, ITs passing

@jdillon
Copy link
Contributor

jdillon commented Jul 19, 2016

why do you need this? seems pretty fragile configuration

@adreghiciu
Copy link
Author

@jdillon By doing boot delegation, class loading will first look in the boot class loader and te boot class loader is the class loader that loads nexus core. This means that plugins cannot include in their dependencies any class that is also in core/core dependencies. This means that if my plugin needs another version of jackson or guava for example as needed by elastic search I cannot do that. Prior osgi version of nexus 2, this was working correctly.

@jdillon
Copy link
Contributor

jdillon commented Jul 26, 2016

@adreghiciu still seems pretty fragile configuration, easy to break whenever something in core changes, and easy to forget to update or miss something important that would otherwise break things.

/me shrugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants