Fix TwinPanelController move buttons

Previous implementation seemed to rely on the side effect that moving DOM nodes also impacted the selected nodes. Fixed the bug and some wacky code.
sonatype · Nov 21, 2012 · 0cfbe13 · 0cfbe13
1 parent 175a0ae
commit 0cfbe13
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/nexus/nexus-webapp/src/main/webapp/js/nexus/ext/twinpanelcontroller.js b/nexus/nexus-webapp/src/main/webapp/js/nexus/ext/twinpanelcontroller.js
@@ -131,14 +131,8 @@ Ext.extend(Nexus.ext.TwinPanelController, Ext.Panel, {
           }
           if (moveAll)
           {
-            for (i = 0; i < fromRoot.childNodes.length; i=i+1)
+            while (fromRoot.firstChild) {
-            {
+              toRoot.appendChild(fromRoot.firstChild);
-              node = fromRoot.childNodes[i];
-              if (checkIfDragAllowed(node))
-              {
-                toRoot.appendChild(node);
-                i = i-1;
-              }
             }
           }
           else
@@ -152,7 +146,6 @@ Ext.extend(Nexus.ext.TwinPanelController, Ext.Panel, {
                 if (checkIfDragAllowed(node))
                 {
                   toRoot.appendChild(node);
-                  i = i-1;
                 }
               }
             }