Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copying assets to dist directory in the default task #128

Closed
ferrarimarco opened this issue May 2, 2016 · 3 comments
Closed

Avoid copying assets to dist directory in the default task #128

ferrarimarco opened this issue May 2, 2016 · 3 comments

Comments

@ferrarimarco
Copy link

ferrarimarco commented May 2, 2016

When running the default task, gulp runs also assets:copy.

Is this useful?

After any edit to Jekyll contents, the dist/assets directory disappears as it's overwritten by Jekyll.
This could lead to an inconsistent, undocumented state. If a dev assumes that the contents of the dist directory always represent the finalized build, he/she could deploy an incomplete artifact with the 'dist/assets' directory missing.

I run the assets:copy task only with the build one, when I know that I am building the final package.

Any thoughts on this? Thanks

EDIT: this could be expanded avoiding the dist directory altogether unless running gulp build.

@sondr3
Copy link
Owner

sondr3 commented May 3, 2016

Huh, I hadn't actually thought of that. Thanks, I'll figure something out for this. Not sure what it'd be though, I'd like for the folder to be in a state where you could upload it without having to run --prod on it as well or having to do gulp build, but I'm not sure there's a good way to do that yet. I'll take a look once I'm done with my exams.

@ferrarimarco
Copy link
Author

ferrarimarco commented May 3, 2016

It could be done by a watch task that on all the .tmp subdirectories (see #127) used to serve content. I'll try to refine my current approach this way and let you know.

@ferrarimarco
Copy link
Author

After completing the work on #127, I can send another PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants